mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed a bug where _ReflectedTypeInstance.isAssignableTo always failed.

Browse source
This commit is contained in:
Tobe O 2018-08-21 10:53:37 -04:00
parent 5f79ec14e5
commit 271db26179
2 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
angel_container/lib/src/mirrors/reflector.dart
View file

@ -71,7 +71,13 @@ class _ReflectedTypeMirror extends ReflectedType {
@override @override
bool isAssignableTo(ReflectedType other) { bool isAssignableTo(ReflectedType other) {
return other is _ReflectedTypeMirror && mirror.isAssignableTo(other.mirror); if (other is _ReflectedClassMirror) {
return mirror.isAssignableTo(other.mirror);
} else if (other is _ReflectedTypeMirror) {
return mirror.isAssignableTo(other.mirror);
} else {
return false;
}
} }
@override @override
@ -136,7 +142,13 @@ class _ReflectedClassMirror extends ReflectedClass {
@override @override
bool isAssignableTo(ReflectedType other) { bool isAssignableTo(ReflectedType other) {
return other is _ReflectedTypeMirror && mirror.isAssignableTo(other.mirror); if (other is _ReflectedClassMirror) {
return mirror.isAssignableTo(other.mirror);
} else if (other is _ReflectedTypeMirror) {
return mirror.isAssignableTo(other.mirror);
} else {
return false;
}
} }
@override @override

15
angel_container/test/common.dart
View file

@ -69,6 +69,17 @@ void testReflector(Reflector reflector) {
expect(instance.name, 'Charizard'); expect(instance.name, 'Charizard');
expect(instance.type, PokemonType.fire); expect(instance.type, PokemonType.fire);
}); });
test('isAssignableTo', () {
var pokemonType = container.reflector.reflectType(Pokemon);
var kantoPokemonType = container.reflector.reflectType(KantoPokemon);
expect(kantoPokemonType.isAssignableTo(pokemonType), true);
expect(
kantoPokemonType
.isAssignableTo(container.reflector.reflectType(String)),
false);
});
} }
class LowerPokemon { class LowerPokemon {
@ -93,4 +104,8 @@ class Pokemon {
String toString() => 'NAME: $name, TYPE: $type'; String toString() => 'NAME: $name, TYPE: $type';
} }
class KantoPokemon extends Pokemon {
KantoPokemon(String name, PokemonType type) : super(name, type);
}
enum PokemonType { water, fire, grass, ice, poison, flying } enum PokemonType { water, fire, grass, ice, poison, flying }