From 3599e83ecf978587fe9e9619610a63bf63c80c26 Mon Sep 17 00:00:00 2001 From: thosakwe Date: Thu, 3 Aug 2017 12:42:16 -0400 Subject: [PATCH] Remove reopen --- CHANGELOG.md | 2 ++ lib/src/http/response_context.dart | 18 ------------------ 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db0ebd82..0fec777b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ patterns, to prevent memory leaks. * Removed the inheritance on `Extensible` in many classes, and removed it from `angel_route`. Now, only `Angel` and `RequestContext` have `@proxy` annotations. * Deprecated passing `debug` to Angel. +* `_LockableBytesBuilder` now uses `Uint8List`. +* Removed `reopen` from `ResponseContext`. # 1.0.7+2 Changed `ResponseContext.serialize`. The `contentType` is now set *before* serialization. diff --git a/lib/src/http/response_context.dart b/lib/src/http/response_context.dart index 08bd6972..3ce2b4f7 100644 --- a/lib/src/http/response_context.dart +++ b/lib/src/http/response_context.dart @@ -145,16 +145,6 @@ class ResponseContext implements StringSink { _isOpen = false; } - /// Re-opens a closed response. **NEVER USE THIS IN A PLUGIN**. - /// - /// To preserve your sanity, don't use it ever. This is solely for internal use. - /// - /// You're going to need this one day, and you'll be happy it was added. - void reopen() { - _buffer._reopen(); - _isOpen = true; - } - /// Sets a response header to the given value, or retrieves its value. @Deprecated('Please use `headers` instead.') header(String key, [String value]) { @@ -361,8 +351,6 @@ abstract class _LockableBytesBuilder extends BytesBuilder { factory _LockableBytesBuilder() => new _LockableBytesBuilderImpl(); void _lock(); - - void _reopen(); } class _LockableBytesBuilderImpl implements _LockableBytesBuilder { @@ -376,12 +364,6 @@ class _LockableBytesBuilderImpl implements _LockableBytesBuilder { void _lock() { _closed = true; } - - @override - void _reopen() { - _closed = false; - } - @override void add(List bytes) { if (_closed)