mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle content-encoding and transfer-encoding headers

Browse source 
http.Client decodes responses, so we can drop those headers when responding
Additionally we will reply with header 'content-length: -1' when http.Client decoded a message
This commit is contained in:
denkuy 2018-11-03 02:10:47 +01:00
parent 2d7ae5a547
commit 5e7e62fee2
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
lib/src/proxy_layer.dart
View file

@ -138,19 +138,24 @@ class Proxy {
mediaType = _fallbackMediaType;
}
var proxiedHeaders = new Map<String, String>.from(rs.headers);
/// if [http.Client] does not provide us with a content length
/// OR [http.Client] is about to decode the response (bytecount returned by [http.Response].stream != known length)
/// then we can not provide a value downstream => set to '-1' for 'unspecified length'
var isContentLengthUnknown = rs.contentLength == null ||
rs.headers[HttpHeaders.contentEncodingHeader]?.isNotEmpty == true ||
rs.headers[HttpHeaders.transferEncodingHeader]?.isNotEmpty == true;
var proxiedHeaders = new Map<String, String>.from(rs.headers)
..remove(HttpHeaders.contentEncodingHeader) // drop, http.Client has decoded
..remove(HttpHeaders.transferEncodingHeader) // drop, http.Client has decoded
..[HttpHeaders.contentLengthHeader] = "${isContentLengthUnknown ? '-1' : rs.contentLength}";
res
..contentType = mediaType
..statusCode = rs.statusCode
..headers.addAll(proxiedHeaders);
var stream = rs.stream;
// [upgrading to dart2] Keeping this workaround as a reference. It's not properly typed for dart2
//if (rs.headers[HttpHeaders.contentEncodingHeader] == 'gzip') stream = stream.transform(gzip.encoder);
await stream.pipe(res);
await rs.stream.pipe(res);
return false;
}