From 729a7740db299d8e8d55dc2b5345f54534ca096f Mon Sep 17 00:00:00 2001
From: "thomashii@dukefirehawk.com" <thomashii@dukefirehawk.com>
Date: Sat, 27 Aug 2022 16:01:12 +0800
Subject: [PATCH] Fixed security analysis warnings

---
 packages/security/lib/src/cookie_signer.dart        | 6 ++++--
 packages/security/lib/src/rate_limiting_window.dart | 2 +-
 packages/security/pubspec.yaml                      | 2 ++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/security/lib/src/cookie_signer.dart b/packages/security/lib/src/cookie_signer.dart
index 9816cbe5..07bf14bb 100644
--- a/packages/security/lib/src/cookie_signer.dart
+++ b/packages/security/lib/src/cookie_signer.dart
@@ -92,7 +92,9 @@ class CookieSigner {
   ///
   /// See [createSignedCookie].
   void writeCookies(ResponseContext res, Iterable<Cookie> cookies) {
-    cookies.forEach((c) => writeCookie(res, c));
+    for (var c in cookies) {
+      writeCookie(res, c);
+    }
   }
 
   /// Returns a new cookie, replacing the value of an input
@@ -104,7 +106,7 @@ class CookieSigner {
   /// Where `sig` is the cookie's value, signed with the [hmac].
   Cookie createSignedCookie(Cookie cookie) {
     return cookieWithNewValue(
-        cookie, cookie.value + '.' + computeCookieSignature(cookie.value));
+        cookie, '${cookie.value}.${computeCookieSignature(cookie.value)}');
   }
 
   /// Returns a new [Cookie] that is the same as the input
diff --git a/packages/security/lib/src/rate_limiting_window.dart b/packages/security/lib/src/rate_limiting_window.dart
index 36aea3aa..522d483c 100644
--- a/packages/security/lib/src/rate_limiting_window.dart
+++ b/packages/security/lib/src/rate_limiting_window.dart
@@ -35,7 +35,7 @@ class RateLimitingWindow<User> {
 
   factory RateLimitingWindow.fromJson(Map<String, dynamic> map) {
     return RateLimitingWindow(
-        (map['user'] as User?)!,
+        (map['user'] as User),
         DateTime.parse(map['start_time'] as String),
         int.parse(map['points_consumed'] as String));
   }
diff --git a/packages/security/pubspec.yaml b/packages/security/pubspec.yaml
index 4ccb75a2..bc0f90b5 100644
--- a/packages/security/pubspec.yaml
+++ b/packages/security/pubspec.yaml
@@ -16,6 +16,8 @@ dev_dependencies:
   angel3_validate: ^7.0.0
   belatuk_pretty_logging: ^5.0.0
   test: ^1.21.0
+  logging: ^1.0.0
+  resp_client: ^1.2.0
   lints: ^2.0.0
 dependency_overrides:
   angel3_production: