mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

+1

Browse source
This commit is contained in:
Tobe O 2018-06-08 13:45:01 -04:00
parent 0c3936d602
commit 7d2ad74c27
3 changed files with 22 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -1,3 +1,6 @@
# 1.1.1+1
* Fix a bug that threw when `--observe` was not present.
# 1.1.1 # 1.1.1
* Disable the observatory from pausing the isolate * Disable the observatory from pausing the isolate
on exceptions, because Angel already handles on exceptions, because Angel already handles

19
lib/angel_hot.dart
View file

@ -140,37 +140,36 @@ class HotReloader {
/// Starts listening to requests and filesystem events. /// Starts listening to requests and filesystem events.
Future<HttpServer> startServer([address, int port]) async { Future<HttpServer> startServer([address, int port]) async {
_server = await _generateServer();
if (_paths?.isNotEmpty != true) if (_paths?.isNotEmpty != true)
print( print(
'WARNING: You have instantiated a HotReloader without providing any filesystem paths to watch.'); 'WARNING: You have instantiated a HotReloader without providing any filesystem paths to watch.');
if (!Platform.executableArguments.contains('--observe') &&
!Platform.executableArguments.contains('--enable-vm-service')) {
stderr.writeln(
'WARNING: You have instantiated a HotReloader without passing `--enable-vm-service` or `--observe` to the Dart VM. Hot reloading will be disabled.');
} else {
_client = await vm.vmServiceConnect( _client = await vm.vmServiceConnect(
vmServiceHost ?? 'localhost', vmServicePort ?? 8181); vmServiceHost ?? 'localhost', vmServicePort ?? 8181);
_vmachine ??= await _client.getVM(); _vmachine ??= await _client.getVM();
_mainIsolate ??= _vmachine.isolates.first; _mainIsolate ??= _vmachine.isolates.first;
await _client.setExceptionPauseMode(_mainIsolate.id, 'None'); await _client.setExceptionPauseMode(_mainIsolate.id, 'None');
_server = await _generateServer();
while (!_requestQueue.isEmpty) await _handle(_requestQueue.removeFirst());
_onChange.stream _onChange.stream
.transform(new _Debounce(new Duration(seconds: 1))) .transform(new _Debounce(new Duration(seconds: 1)))
.listen(_handleWatchEvent); .listen(_handleWatchEvent);
await _listenToFilesystem(); await _listenToFilesystem();
}
while (!_requestQueue.isEmpty) await _handle(_requestQueue.removeFirst());
var server = await HttpServer.bind(address ?? '127.0.0.1', port ?? 0); var server = await HttpServer.bind(address ?? '127.0.0.1', port ?? 0);
server.listen(handleRequest); server.listen(handleRequest);
return server; return server;
} }
_listenToFilesystem() async { _listenToFilesystem() async {
if (!Platform.executableArguments.contains('--observe') &&
!Platform.executableArguments.contains('--enable-vm-service')) {
stderr.writeln(
'WARNING: You have instantiated a HotReloader without passing `--enable-vm-service` or `--observe` to the Dart VM. Hot reloading will be disabled.');
return;
}
for (var path in _paths) { for (var path in _paths) {
if (path is String) { if (path is String) {
await _listenToStat(path); await _listenToStat(path);

2
pubspec.yaml
View file

@ -1,6 +1,6 @@
name: angel_hot name: angel_hot
description: Supports hot reloading of Angel servers on file changes. description: Supports hot reloading of Angel servers on file changes.
version: 1.1.1 version: 1.1.1+1
author: Tobe O <thosakwe@gmail.com> author: Tobe O <thosakwe@gmail.com>
homepage: https://github.com/angel-dart/hot homepage: https://github.com/angel-dart/hot
environment: environment: