From 80ec2e10a8c0878b2752e30a3572abb5d4d56f00 Mon Sep 17 00:00:00 2001 From: thomashii Date: Tue, 18 May 2021 17:42:21 +0800 Subject: [PATCH] Update production --- packages/production/CHANGELOG.md | 3 +++ packages/production/README.md | 4 ++-- packages/production/lib/src/runner.dart | 12 +++++++----- packages/production/pubspec.yaml | 2 +- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/packages/production/CHANGELOG.md b/packages/production/CHANGELOG.md index da11eb5d..ab335654 100644 --- a/packages/production/CHANGELOG.md +++ b/packages/production/CHANGELOG.md @@ -1,3 +1,6 @@ +# 3.0.1 +* Fixed static analysis warnings + # 3.0.0 * Migrated to support Dart SDK 2.12.x NNBD diff --git a/packages/production/README.md b/packages/production/README.md index ba3e4cb2..425171bf 100644 --- a/packages/production/README.md +++ b/packages/production/README.md @@ -1,5 +1,5 @@ # angel3_production -[![version](https://img.shields.io/badge/pub-v3.0.0-brightgreen)](https://pub.dartlang.org/packages/angel3_production) +[![version](https://img.shields.io/badge/pub-v3.0.1-brightgreen)](https://pub.dartlang.org/packages/angel3_production) [![Null Safety](https://img.shields.io/badge/null-safety-brightgreen)](https://dart.dev/null-safety) [![Gitter](https://img.shields.io/gitter/room/angel_dart/discussion)](https://gitter.im/angel_dart/discussion) @@ -26,7 +26,7 @@ import 'dart:isolate'; import 'package:angel3_framework/angel3_framework.dart'; import 'package:angel3_production/angel3_production.dart'; -main(List args) => Runner('example', configureServer).run(args); +void main(List args) => Runner('example', configureServer).run(args); Future configureServer(Angel app) async { app.get('/', (req, res) => 'Hello, production world!'); diff --git a/packages/production/lib/src/runner.dart b/packages/production/lib/src/runner.dart index e66ceded..e66392db 100644 --- a/packages/production/lib/src/runner.dart +++ b/packages/production/lib/src/runner.dart @@ -94,7 +94,11 @@ _ ___ | /| / / /_/ / _ /___ _ /___ onError: onError.sendPort, errorsAreFatal: true && false) .then((isolate) {}) - .catchError(c.completeError); + //.catchError(c.completeError); + .catchError((e) { + c.completeError(e as Object); + return null; + }); onLogRecord.listen((msg) => handleLogRecord(msg as LogRecord?, options)); @@ -213,10 +217,8 @@ _ ___ | /| / / /_/ / _ /___ _ /___ await app.configure(args.configureServer); - if (app.logger == null) { - app.logger = Logger(args.loggerName) - ..onRecord.listen((rec) => Runner.handleLogRecord(rec, args.options)); - } + app.logger ??= Logger(args.loggerName) + ..onRecord.listen((rec) => Runner.handleLogRecord(rec, args.options)); AngelHttp http; late SecurityContext securityContext; diff --git a/packages/production/pubspec.yaml b/packages/production/pubspec.yaml index 5e272441..931c660a 100644 --- a/packages/production/pubspec.yaml +++ b/packages/production/pubspec.yaml @@ -1,5 +1,5 @@ name: angel3_production -version: 3.0.0 +version: 3.0.1 description: Helpers for concurrency, message-passing, rotating loggers, and other production functionality in Angel. homepage: https://github.com/dukefirehawk/angel/tree/angel3/packages/production environment: