mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reflecting void in MirrorsReflector now forwards to dynamic.

Browse source
This commit is contained in:
Tobe O 2018-08-20 22:32:06 -04:00
parent cb977c84e2
commit a9c1b7ff0d
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
angel_container/CHANGELOG.md
View file

@ -1,3 +1,6 @@
# 1.0.0-alpha.4
* Safely handle `void` return types of methods.
# 1.0.0-alpha.3 # 1.0.0-alpha.3
* Reflecting `void` in `MirrorsReflector` now forwards to `dynamic`. * Reflecting `void` in `MirrorsReflector` now forwards to `dynamic`.

8
angel_container/lib/src/mirrors/reflector.dart
View file

@ -33,7 +33,7 @@ class MirrorsReflector implements Reflector {
ReflectedType reflectType(Type type) { ReflectedType reflectType(Type type) {
var mirror = dart.reflectType(type); var mirror = dart.reflectType(type);
if (mirror.hasReflectedType) { if (!mirror.hasReflectedType) {
return reflectType(dynamic); return reflectType(dynamic);
} else { } else {
if (mirror is dart.ClassMirror) { if (mirror is dart.ClassMirror) {
@ -185,8 +185,10 @@ class _ReflectedMethodMirror extends ReflectedFunction {
mirror.metadata mirror.metadata
.map((mirror) => new _ReflectedInstanceMirror(mirror)) .map((mirror) => new _ReflectedInstanceMirror(mirror))
.toList(), .toList(),
const MirrorsReflector() !mirror.returnType.hasReflectedType
.reflectType(mirror.returnType.reflectedType), ? const MirrorsReflector().reflectType(dynamic)
: const MirrorsReflector()
.reflectType(mirror.returnType.reflectedType),
mirror.parameters.map(_reflectParameter).toList(), mirror.parameters.map(_reflectParameter).toList(),
mirror.isGetter, mirror.isGetter,
mirror.isSetter); mirror.isSetter);

2
angel_container/pubspec.yaml
View file

@ -1,5 +1,5 @@
name: angel_container name: angel_container
version: 1.0.0-alpha.3 version: 1.0.0-alpha.4
author: Tobe O <thosakwe@gmail.com> author: Tobe O <thosakwe@gmail.com>
description: "A better IoC container and dependency injector for Angel, ultimately allowing Angel to be used without dart:mirrors." description: "A better IoC container and dependency injector for Angel, ultimately allowing Angel to be used without dart:mirrors."
homepage: https://github.com/angel-dart/container.git homepage: https://github.com/angel-dart/container.git