mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add warning when no reflector is given

Browse source
This commit is contained in:
Tobe O 2019-04-08 18:51:22 -04:00
parent 62709c0bbd
commit ef45d98a45
3 changed files with 20 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -1,3 +1,6 @@
# 2.0.0-rc.0
* Log a warning when no `reflector` is provided.
# 2.0.0-alpha.24 # 2.0.0-alpha.24
* Add `AngelEnv` class to `core`. * Add `AngelEnv` class to `core`.
* Deprecate `Angel.isProduction`, in favor of `AngelEnv`. * Deprecate `Angel.isProduction`, in favor of `AngelEnv`.

17
example/main.dart
View file

@ -4,18 +4,15 @@ import 'package:angel_framework/http.dart';
import 'package:logging/logging.dart'; import 'package:logging/logging.dart';
main() async { main() async {
var app = new Angel( // Logging set up/boilerplate
Logger.root.onRecord.listen(print);
// Create our server.
var app = Angel(
logger: Logger('angel'), logger: Logger('angel'),
reflector: MirrorsReflector(), reflector: MirrorsReflector(),
); );
app.logger = new Logger('angel')
..onRecord.listen((rec) {
print(rec);
if (rec.error != null) print(rec.error);
if (rec.stackTrace != null) print(rec.stackTrace);
});
// Index route. Returns JSON. // Index route. Returns JSON.
app.get('/', (req, res) => 'Welcome to Angel!'); app.get('/', (req, res) => 'Welcome to Angel!');
@ -44,12 +41,12 @@ main() async {
// Simple fallback to throw a 404 on unknown paths. // Simple fallback to throw a 404 on unknown paths.
app.fallback((req, res) { app.fallback((req, res) {
throw new AngelHttpException.notFound( throw AngelHttpException.notFound(
message: 'Unknown path: "${req.uri.path}"', message: 'Unknown path: "${req.uri.path}"',
); );
}); });
var http = new AngelHttp(app); var http = AngelHttp(app);
var server = await http.startServer('127.0.0.1', 3000); var server = await http.startServer('127.0.0.1', 3000);
var url = 'http://${server.address.address}:${server.port}'; var url = 'http://${server.address.address}:${server.port}';
print('Listening at $url'); print('Listening at $url');

13
lib/src/core/server.dart
View file

@ -3,8 +3,6 @@ library angel_framework.http.server;
import 'dart:async'; import 'dart:async';
import 'dart:collection' show HashMap; import 'dart:collection' show HashMap;
import 'dart:convert'; import 'dart:convert';
import 'dart:io';
import 'package:angel_container/angel_container.dart'; import 'package:angel_container/angel_container.dart';
import 'package:angel_http_exception/angel_http_exception.dart'; import 'package:angel_http_exception/angel_http_exception.dart';
import 'package:angel_route/angel_route.dart'; import 'package:angel_route/angel_route.dart';
@ -13,7 +11,6 @@ import 'package:http_parser/http_parser.dart';
import 'package:logging/logging.dart'; import 'package:logging/logging.dart';
import 'package:mime/mime.dart'; import 'package:mime/mime.dart';
import 'package:tuple/tuple.dart'; import 'package:tuple/tuple.dart';
import 'controller.dart'; import 'controller.dart';
import 'env.dart'; import 'env.dart';
import 'hooked_service.dart'; import 'hooked_service.dart';
@ -357,6 +354,16 @@ class Angel extends Routable {
this.serializer, this.serializer,
this.viewGenerator}) this.viewGenerator})
: super(reflector) { : super(reflector) {
if (reflector == const EmptyReflector()) {
var msg =
'No `reflector` was passed to the Angel constructor, so reflection will not be available.\n'
'Features like controllers, constructor dependency injection, and `ioc` require reflection, '
'and will not work without it.\n\n'
'For more, see the documentation:\n'
'https://docs.angel-dart.dev/guides/dependency-injection#enabling-dart-mirrors-or-other-reflection';
logger?.warning(msg);
}
bootstrapContainer(); bootstrapContainer();
viewGenerator ??= noViewEngineConfigured; viewGenerator ??= noViewEngineConfigured;
serializer ??= json.encode; serializer ??= json.encode;