mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* Always put ORDER BY before LIMIT.

Browse source
This commit is contained in:
Tobe O 2019-08-17 18:08:49 -04:00
parent fa01fd982e
commit f18c23c5f9
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
angel_orm/CHANGELOG.md
View file

@ -6,6 +6,7 @@ callbacks.
* Make `JoinBuilder` take `to` as a `String Function()`. This will allow * Make `JoinBuilder` take `to` as a `String Function()`. This will allow
ORM queries to reference their joined subqueries. ORM queries to reference their joined subqueries.
* Removed deprecated `Join`, `toSql`, `sanitizeExpression`, `isAscii`. * Removed deprecated `Join`, `toSql`, `sanitizeExpression`, `isAscii`.
* Always put `ORDER BY` before `LIMIT`.
# 2.0.1 # 2.0.1
* Apply `package:pedantic` fixes. * Apply `package:pedantic` fixes.

4
angel_orm/lib/src/query.dart
View file

@ -241,12 +241,12 @@ abstract class Query<T, Where extends QueryWhere> extends QueryBase<T> {
var whereClause = var whereClause =
where.compile(tableName: includeTableName ? tableName : null); where.compile(tableName: includeTableName ? tableName : null);
if (whereClause.isNotEmpty) b.write(' WHERE $whereClause'); if (whereClause.isNotEmpty) b.write(' WHERE $whereClause');
if (_limit != null) b.write(' LIMIT $_limit');
if (_offset != null) b.write(' OFFSET $_offset');
if (_groupBy != null) b.write(' GROUP BY $_groupBy'); if (_groupBy != null) b.write(' GROUP BY $_groupBy');
for (var item in _orderBy) { for (var item in _orderBy) {
b.write(' ORDER BY ${item.compile()}'); b.write(' ORDER BY ${item.compile()}');
} }
if (_limit != null) b.write(' LIMIT $_limit');
if (_offset != null) b.write(' OFFSET $_offset');
return b.toString(); return b.toString();
} }