mrpastewart/platform
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed security analysis warnings

Browse source
This commit is contained in:
thomashii@dukefirehawk.com 2022-08-27 16:01:12 +08:00
parent 45218176c7
commit 729a7740db
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/security/lib/src/cookie_signer.dart
View file

@ -92,7 +92,9 @@ class CookieSigner {
/// ///
/// See [createSignedCookie]. /// See [createSignedCookie].
void writeCookies(ResponseContext res, Iterable<Cookie> cookies) { void writeCookies(ResponseContext res, Iterable<Cookie> cookies) {
cookies.forEach((c) => writeCookie(res, c)); for (var c in cookies) {
writeCookie(res, c);
}
} }
/// Returns a new cookie, replacing the value of an input /// Returns a new cookie, replacing the value of an input
@ -104,7 +106,7 @@ class CookieSigner {
/// Where `sig` is the cookie's value, signed with the [hmac]. /// Where `sig` is the cookie's value, signed with the [hmac].
Cookie createSignedCookie(Cookie cookie) { Cookie createSignedCookie(Cookie cookie) {
return cookieWithNewValue( return cookieWithNewValue(
cookie, cookie.value + '.' + computeCookieSignature(cookie.value)); cookie, '${cookie.value}.${computeCookieSignature(cookie.value)}');
} }
/// Returns a new [Cookie] that is the same as the input /// Returns a new [Cookie] that is the same as the input

2
packages/security/lib/src/rate_limiting_window.dart
View file

@ -35,7 +35,7 @@ class RateLimitingWindow<User> {
factory RateLimitingWindow.fromJson(Map<String, dynamic> map) { factory RateLimitingWindow.fromJson(Map<String, dynamic> map) {
return RateLimitingWindow( return RateLimitingWindow(
(map['user'] as User?)!, (map['user'] as User),
DateTime.parse(map['start_time'] as String), DateTime.parse(map['start_time'] as String),
int.parse(map['points_consumed'] as String)); int.parse(map['points_consumed'] as String));
} }

2
packages/security/pubspec.yaml
View file

@ -16,6 +16,8 @@ dev_dependencies:
angel3_validate: ^7.0.0 angel3_validate: ^7.0.0
belatuk_pretty_logging: ^5.0.0 belatuk_pretty_logging: ^5.0.0
test: ^1.21.0 test: ^1.21.0
logging: ^1.0.0
resp_client: ^1.2.0
lints: ^2.0.0 lints: ^2.0.0
dependency_overrides: dependency_overrides:
angel3_production: angel3_production: